Conversation
bfcb453 to
56af80c
Compare
43e6cd2 to
2b75c36
Compare
4a5ed35 to
0e92483
Compare
There was a problem hiding this comment.
Looks like we've got all the data we need here, now to make a corresponding Producer.cpp file containing constructor implementations and with the implementations of get_profitability_yesterday and get_average_profitability_last_seven_days moved into it.
One thing to bear in mind: derived class constructors can't directly initialise their base class' variables, they have to call the base class' constructor.
Also can you rebase this onto master to include recent changes.
c53e9b8 to
773b1f4
Compare
There was a problem hiding this comment.
I would also really prefer all the maros be prefixed with OV_ or _OV_ depending on expected use case, those which you use directly should be OV_, those you usually don't should be _OV_, and something like value_or_move should be in a namespace even if its in macros like
namespace OpenVic::detail {
template<typename T>
constexpr T value_or_move(T&& value);
}
#define MACRO(Arg) ::OpenVic::detail::value_or_move(Arg);7640ad0 to
e98cd1f
Compare
No description provided.